Every ticket as the root of its provenance graph — goal, patch, approval, runs and (as the ticket-class build lands) mandate, manifestations, guarantees, journey, artifacts and children. Rendered through the <<<TicketGraphList>>> tag.
goal
THIS UNIT SUPERSEDES #290 — it is the SAME module and the same work, re-filed to be
SELF-CONTAINED. The superseded unit named its source only as a `git cat-file` command
against the forge's bare repos, which the sandboxed pair_loop worker that executes these
tickets cannot run, so it could not be done as filed (#346; #259 is the proof). A ticket body
is permanent in SQL (tg_tickets_immutable_identity, migrations/0029_ticket_authorization
.sql:111-117), so that body could not be repaired — this ticket carries the fix instead, and
the original is halted by a stop ticket rather than erased. Do the work HERE.
Rewrite ONE unique forge module as entirely new, behavior-preserving, installable,
control-config'd Python, per the FORGE-wide refactor standard #200 (#std).
This ticket covers ONE module — the one identified below — and nothing else. It was filed
against the module's DEDUPLICATED identity, so if that module was copy-pasted across the
forge, every copy is covered by this single ticket.
MODULE KEY : forge-rw:300ba60b5fceb278
(the ticketer's idempotency marker — it lives in this ticket's TITLE. Do
not edit the title, or the module will be re-filed as a duplicate.)
IDENTITY : AST-NORMALIZED — codebean's `_ast_norm` (#183), i.e.
ast.dump(ast.parse(ast.unparse(ast.parse(src)))).
Copies of this module that differ only in comments, blank lines,
quoting or spacing carry the SAME module-sha and are covered by THIS
ticket. A differing docstring is real content, so a module whose
docstring differs is a DIFFERENT module with its own ticket.
SIZE : 2907 bytes
EXTENSION : .py
CANONICAL SOURCE (the location this ticket is named for):
repo : code__code-invalid__coupler
path : coupler/tests/test_build.py
ref : refs/heads/stable (as recorded when this module was first filed)
blob : c1878c75ae86094d456902cb6227cc1212412fa9 (git blob sha1)
REFERENCE ONLY — you do NOT need this command. This module's bytes are embedded
COMPLETE in THE ORIGINAL SOURCE block below, and that is what the rewrite is based
on. For a reader who does have forge access:
git --git-dir=/Users/stevenpeterson/code/installed/jazz-project/config/forge/remotes/code__code-invalid__coupler.git cat-file blob c1878c75ae86094d456902cb6227cc1212412fa9
THE SAME MODULE ALSO LIVES AT THESE FORGE TIPS — 2 copy/copies. They SHARE THIS
ticket: this module is rewritten ONCE, and every location below is satisfied by
that one rewrite. Do not file a ticket per copy.
coupler:coupler/tests/test_build.py
gitlab__testmonkeyalpha__coupler:coupler/tests/test_build.py
HISTORICAL OCCURRENCES of this exact blob — every OTHER DISTINCT {repo, path}
the omni-git index (`occ`, joined on the git blob sha1) records this
byte-identical file at, with the index's own `ts` for the first row of each.
Any place this run enumerated LIVE is listed under the forge tips above, not
here. Context for the rewrite, not extra work:
testmonkeyalpha/coupler:coupler/tests/test_build.py [occ.ts gitlab]
THE ORIGINAL SOURCE, EMBEDDED — YOU NEED NO FORGE ACCESS TO DO THIS TICKET.
The module's own bytes are reproduced below, inside this ticket. THEY are the
authoritative copy and the behavior-preserving basis: rewrite from them. The
`git --git-dir=... cat-file blob` command under CANONICAL SOURCE above is kept only as a
REFERENCE for a reader who happens to have forge access — running it is NOT part of this
ticket. (Why the bytes are here at all: the pair_loop worker that executes this ticket is
sandboxed to the ticket's own congruency worktree and cannot read the forge's bare repos.
Ticket #346 is the fix that put them on the ticket.)
The block BEGINS at the line
===ORIGINAL SOURCE (verbatim, the behavior-preserving basis)===
and ENDS at the first line
===END SOURCE===
Everything strictly between those two lines is the module — 2907 byte(s), byte for byte, with no re-indentation, no re-wrapping and nothing
elided.
===ORIGINAL SOURCE (verbatim, the behavior-preserving basis)===
"""
Unit tests for build resolution — _load_build, _notes_python.
No live services required.
"""
import json
from pathlib import Path
import pytest
@pytest.fixture
def fake_jazz(tmp_path, monkeypatch):
env_dir = tmp_path / "conf" / "env"
env_dir.mkdir(parents=True)
(env_dir / "build.json").write_text(json.dumps({
"version": "1.0.42",
"tag": "v1.0.42",
"build": 42,
"envs": {"notes": "notes-jazz-1.0.42"},
}))
monkeypatch.setenv("JAZZ_ROOT", str(tmp_path))
monkeypatch.setenv("JAZZ_DEV", "/nonexistent")
return tmp_path
@pytest.fixture
def mod(fake_jazz):
import importlib
import coupler.server as m
importlib.reload(m)
return m
def test_load_build_reads_version(mod):
b = mod._load_build()
assert b["version"] == "1.0.42"
assert b["envs"]["notes"] == "notes-jazz-1.0.42"
def test_load_build_missing_returns_empty(tmp_path, monkeypatch):
monkeypatch.setenv("JAZZ_ROOT", str(tmp_path))
monkeypatch.setenv("JAZZ_DEV", "/nonexistent")
import importlib
import coupler.server as m
importlib.reload(m)
assert m._load_build() == {}
def test_notes_python_fallback_when_env_missing(mod):
"""Versioned conda env doesn't exist → falls back to base python."""
python = mod._notes_python()
assert Path(python).exists()
assert "python" in python
def test_notes_python_uses_versioned_env(tmp_path, monkeypatch):
"""Uses versioned env python when the path exists."""
# create a fake versioned python
fake_env = tmp_path / "envs" / "notes-jazz-1.0.42" / "bin"
fake_env.mkdir(parents=True)
fake_python = fake_env / "python"
fake_python.touch()
fake_python.chmod(0o755)
env_dir = tmp_path / "conf" / "env"
env_dir.mkdir(parents=True)
(env_dir / "build.json").write_text(json.dumps({
"version": "1.0.42",
"envs": {"notes": "notes-jazz-1.0.42"},
}))
monkeypatch.setenv("JAZZ_ROOT", str(tmp_path))
monkeypatch.setenv("JAZZ_DEV", "/nonexistent")
# patch the conda base path
import importlib
import coupler.server as m
original = m._notes_python.__code__
# monkeypatch the base path inside _notes_python by overriding the candidate path
real_fn = m._notes_python
def patched():
build = m._load_build()
envs = build.get("envs", {})
notes_env = envs.get("notes", "")
if notes_env:
candidate = str(tmp_path / "envs" / notes_env / "bin" / "python")
if Path(candidate).exists():
return candidate
return "/opt/homebrew/Caskroom/miniconda/base/bin/python"
monkeypatch.setattr(m, "_notes_python", patched)
importlib.reload(m)
# reload resets the monkeypatch — just call patched directly
result = patched()
assert result == str(tmp_path / "envs" / "notes-jazz-1.0.42" / "bin" / "python")
===END SOURCE===
THE CALLABLE SURFACE — every callable in the original, lowered with codebean's
`lower_node` (#183). The rewrite must present THIS surface (same names, same
parameters, same defaults) so callers of the original keep working:
fake_jazz(tmp_path, monkeypatch)
mod(fake_jazz)
test_load_build_reads_version(mod)
test_load_build_missing_returns_empty(tmp_path, monkeypatch)
test_notes_python_fallback_when_env_missing(mod)
test_notes_python_uses_versioned_env(tmp_path, monkeypatch)
CAPTURED BEHAVIORAL EXEMPLARS: none. no function in this module is minable — criteria_miner mines only
self-contained pure functions (it refuses anything that mentions a
world-touching or non-deterministic name, plus methods and no-arg
functions), and nothing here qualified
This does NOT weaken the ticket's bar — it MOVES the work: you must write the
equivalence exemplars by hand from the original's behavior before rewriting, and
they are what settles this ticket.
THE STANDARD — #200's four requirements, which this ticket exists to enforce. All four are
the standard's own words; none is optional:
1. BEHAVIOR-PRESERVING, VERIFIED NOT ASSERTED — the deliverable is ENTIRELY NEW source
code (rewritten, not copied). It must reproduce the ORIGINAL's behavior, and the proof
is the exemplars above (captured via codebean lower_* #183 + criteria_miner
IO-exemplars, exactly as #200 specifies).
2. A PYTHON MODULE — regardless of the source language. This module's source is `.py`;
the rewrite is Python either way.
3. INSTALLABLE — a proper package: pyproject.toml, `pip install -e .` works, console
entry points where applicable.
4. CONTROL-CONFIG'D — NO hardcoded paths or params. A JSON/registry config object drives
it (the install.json / registry.json idiom of this repo), and per note-for-claude a
tool that cannot see its config THROWS rather than guessing a default.
ACCEPTANCE (#200's, per rewrite ticket) — this ticket settles when ALL of:
a. the new source reproduces every captured exemplar above, plus the edge cases you add
for what sampling cannot reach (paste the runs as evidence);
b. it presents the callable surface above, so existing callers keep working;
c. `pip install -e .` installs it clean from its own pyproject.toml;
d. it runs off a config object with ZERO hardcoded settings, and throws without one.
Kind is `build` (a pair: coder + adversarial tester). This ticket hangs off #200 by a
`spawned` edge, so a stop ticket aimed at #200 brakes every rewrite in this programme.
Filed mechanically by checkouts/current/congruency/tools/forge_refactor_ticketer.py under ticket #201, from the forge bare repos at
/Users/stevenpeterson/code/installed/jazz-project/config/forge/remotes. Its original source is embedded above (#346), so this ticket is complete on its own.